[ 
https://issues.apache.org/jira/browse/TAJO-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942662#comment-13942662
 ] 

Hyunsik Choi commented on TAJO-684:
-----------------------------------

Hi [~alvinhenrick],

Welcome to Tajo project. Thank you for your contribution. 
In overall, the patch looks nice for me. I have some comments on your patch.
For easy review, could you mind uploading your patch to the review board? 
https://reviews.apache.org/dashboard/

> Add functions about time
> ------------------------
>
>                 Key: TAJO-684
>                 URL: https://issues.apache.org/jira/browse/TAJO-684
>             Project: Tajo
>          Issue Type: Task
>          Components: function/udf
>    Affects Versions: 0.8-incubating, 1.0-incubating
>            Reporter: Jihoon Son
>            Assignee: Alvin Henrick
>              Labels: patch
>         Attachments: TAJO-684-With-ASF-Unit-Test.patch, 
> TAJO-684-WithUnitTest.patch, TAJO-684.patch
>
>
> Functions about time such as utc_usec_to_second(), utc_usec_to_minute(), 
> utc_usec_to_hour(), utc_usec_to_day(), utc_usec_to_week(), utc_usec_to_year() 
> are popularly used in many applications.
> These functions are useful when we group data with tome intervals. 
> For example, utc_usec_to_day() works as follows. 
> {noformat}
> tajo> select utc_usec_to_day(1274259481071200);
> 1274227200000000
> {noformat}
> We need to provide these functions by default.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to