[ 
https://issues.apache.org/jira/browse/TEZ-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075049#comment-14075049
 ] 

Siddharth Seth commented on TEZ-1058:
-------------------------------------

Only looked at the chanegs (not for other interfaces etc that may need change - 
will do that later).
- EdgeManager, VertexManagerPlugin, TezRootInputInitializer, possibly others - 
Need to be marked Public. (Currently they're only annotated with unstable). 
Public, Unstable
- MemoryUpdateCallback - javadocs need to be changed since this can no longer 
be implemented by Inputs/Outputs/Processors. Instead the single implementation 
that exists should ideally be used.
- *Context javadoc should mention that these interfaces are not meant to be 
implemented. I'll create a separate jira for this.

Otherwise looks good.

> Replace user land interfaces with abstract classes
> --------------------------------------------------
>
>                 Key: TEZ-1058
>                 URL: https://issues.apache.org/jira/browse/TEZ-1058
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>            Priority: Blocker
>         Attachments: TEZ-1058.1.patch
>
>
> Similar to Input/Processor/Output, there are other interfaces that users may 
> implement. These should move to abstract classes for better compatibility 
> management and sharing common basic functionality in the base abstract class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to