[ 
https://issues.apache.org/jira/browse/TEZ-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated TEZ-1341:
----------------------------------

    Attachment: Screen Shot 2014-07-31 at 4.07.28 AM.png
                TEZ-1341.2.patch

{code}
checkArgument((key == REPEAT_KEY || key.getClass() == keyClass),
  "wrong key class: " + key.getClass() + " is not " + keyClass);
checkState(keyLength >= 0, "Negative key-length not allowed: "
  + keyLength + " for " + key);
{code}

These were the causes of the issue (Attached the profiler snapshot after the 
fix). 

Agreed that additional checks should not be removed as a part of this.  
Reverted those changes in the latest patch.

> Regression: IFile append() has string concats leading to memory pressure
> ------------------------------------------------------------------------
>
>                 Key: TEZ-1341
>                 URL: https://issues.apache.org/jira/browse/TEZ-1341
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>              Labels: performance
>         Attachments: Screen Shot 2014-07-30 at 4.54.22 PM.png, Screen Shot 
> 2014-07-31 at 4.07.28 AM.png, TEZ-1341.1.patch, TEZ-1341.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to