[
https://issues.apache.org/jira/browse/TEZ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089873#comment-14089873
]
Bikas Saha commented on TEZ-1386:
---------------------------------
Looks good. +1.
This jira is not really targeting making TezGrouping transparent. I think there
may a more transparent way of doing that. Will open a jira for that to gather
comments.
Please add some javadoc saying that the input format config will be changed if
grouping is enabled.
Please remove superfluous code in MRRReader* and other places.
> Users should not need to setup TezGroupedInputFormat to enable grouping
> -----------------------------------------------------------------------
>
> Key: TEZ-1386
> URL: https://issues.apache.org/jira/browse/TEZ-1386
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1386.1.txt, TEZ-1386.2.txt
>
>
> To enable grouping via Tez, users should not need to change the underlying
> InputFormat. A simple enable / disable option should be sufficient.
> MRInputConfigurer does this.
> Many of the methods in MRHelpers, however, require an InputFormat to be
> specified. The main objective of this JIRA is to get rid of this requirement
> in favor of a simple enableGrouping flag.
> Marking this as a blocker for TEZ-1347, since it should simplify the set of
> APIs required. Also, making all the changes in TEZ-1347 would just lead to a
> very large patch.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
