[
https://issues.apache.org/jira/browse/TEZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096721#comment-14096721
]
Siddharth Seth commented on TEZ-671:
------------------------------------
Mostly looks good.
- Why is the configuration==null check required in ACLManager ?
{code}
+ } else {
+ aclsEnabled = true;
+ }
{code}
TEZ_DAG_VIEW_ACLS, TEZ_DAG_MODIFY_ACLS are private. Do we want users setting
these via tez-site.xml ? If not, ideally, these could be sent via their own
proto field, and then just sent into the ACLManager/Parser as strings. This is
OK, but we should mark them private.
DAGAccessControls. I'm guessing this is designed to be used as
DAG.setAccessControls(new
DAGAccessCOntrols().setUsersWithViewAcls(conf.getStrings(conf_property_name) ?
Would be helpful to have some defaults like - ALLLOW_ALL, ALLOW_NONE. Also, a
constructor which just accepts the standard MR ACLs may be useful, since we
support that format for the AM ACLs in any case.
> Support View/Modify ACLs for DAGs
> ---------------------------------
>
> Key: TEZ-671
> URL: https://issues.apache.org/jira/browse/TEZ-671
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Hitesh Shah
> Attachments: TEZ-671.2.patch, TEZ-671.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
