[
https://issues.apache.org/jira/browse/TEZ-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097373#comment-14097373
]
Bikas Saha commented on TEZ-1416:
---------------------------------
bq. Also, I saw TEZ_AM_CONTAINER_REUSE_LOCALITY_DELAY_ALLOCATION_MILLIS_DEFAULT
getting changed to 250 - is that intentional?
Does not seem right to set such a low value for the general case?
Its probably a good value for small clusters where folks usually try out Tez.
For larger clusters, things need to be customized but thats true for other
configs as well. I am thinking of reducing a few other timeouts like am rm
heartbeat.
I skipped TezCounters because it wasnt clear to me what should be visible. From
what I see only the enums and TezCounter/Group needs to be visible. The rest
can be marked private.
These should not be private IMO since they are meant to tune num counters to
fit within memory, right?
TEZ_AM_COUNTERS_MAX_KEYS
I did not move these to tez-constants because IMO they dont need to. Its should
be fine to rename them to something else. As opposed to renaming the dag app
master class which wont work.
public static final String TEZ_PB_BINARY_CONF_NAME = "tez-conf.pb";
public static final String TEZ_PB_PLAN_BINARY_NAME = "tez-dag.pb";
Will skip the proto files and mark them private.
> tez-api project javadoc/annotations review and clean up.
> --------------------------------------------------------
>
> Key: TEZ-1416
> URL: https://issues.apache.org/jira/browse/TEZ-1416
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Blocker
> Attachments: TEZ-1416.1.patch, TEZ-1416.1.patch.review
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
