[
https://issues.apache.org/jira/browse/TEZ-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098181#comment-14098181
]
Siddharth Seth commented on TEZ-1334:
-------------------------------------
TezBytesWritableSerialization and TezBytesComparator go together. They should
have similar annotations. These will be used by Hive, so Public seems correct -
I'd say Unstable. Maybe event LimitedPrivate for Hive. At the moment this is
useful only for BytesWritable.
ScalingAllocator is missing an annotation. Should any of these allocators be
marked as public ? They are enabled by default - and technically users can
configure them.
On the InputAlreadyClosedException - I think it should just extend
TezUncheckedException. Processor have a handle on Inputs / Outputs event after
they're closed - it's a mechanism to indicate this.
Other than that, looks good to me.
> Annotate all non public classes in tez-runtime-library with @private
> --------------------------------------------------------------------
>
> Key: TEZ-1334
> URL: https://issues.apache.org/jira/browse/TEZ-1334
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Hitesh Shah
> Priority: Blocker
> Attachments: TEZ-1334.1.patch, TEZ-1334.2.patch
>
>
> This prevents javadoc from being generated.
> Alternative would be to mark classes explicitly public using annotation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
