[ 
https://issues.apache.org/jira/browse/TEZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104720#comment-14104720
 ] 

Jonathan Eagles commented on TEZ-1363:
--------------------------------------

Yes, a fully detailed review is in order. This code is working without fault on 
the limited jobs I have tested against it.

* I will see if I can leverage the AMRMClientAysnc or TezAMRMClientAysnc 
directly since it has very few assumptions for an abstract class.
* As far as blacklist is concerned, TestLocalMode fails with blacklisting 
enabled since the TaskScheduler assume the local node should be blacklisted. I 
could implement the feature and just disable blacklisting for the TestLocalMode 
"failing tests"
* LocalTaskScheduler is no longer used with the patch and will be removed

> Make use of the regular scheduler when running in LocalMode
> -----------------------------------------------------------
>
>                 Key: TEZ-1363
>                 URL: https://issues.apache.org/jira/browse/TEZ-1363
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-1363-v1.patch, TEZ-1363-v2.patch, TEZ-1363-v3.patch
>
>
> In TEZ-708, we decided to introduce a new scheduler for local mode - to keep 
> things simple initially, and get local mode working.
> Eventually, however, scheduling should go through the regular task scheduler 
> - which should be able to get containers from YARN / LocalAllocator / other 
> sources - and treat them as a regular container for scheduling purposes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to