[
https://issues.apache.org/jira/browse/TEZ-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122840#comment-14122840
]
Jeff Zhang commented on TEZ-1384:
---------------------------------
[~hitesh] Attach the patch
* Create a base class EntityRecoveryService to better illustrate the function
and purpose of these inner class. Also add docs for this class.
* do more refactoring based on your comments.
bq. Is all the code just re-factored to move into an inner class or there were
other changes also done? Also, the original objective of the re-factoring was
to keep the stored and restored state in sync - however, the inner class seems
to be updated data in the parent class - is that intentional?
The inner class just do the recovery related work ( store historyevent, restore
historyevent and recover ). Parent class just call the inner class's api, won't
change its data directly.
> Move recovery related code into inner class
> -------------------------------------------
>
> Key: TEZ-1384
> URL: https://issues.apache.org/jira/browse/TEZ-1384
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: Tez-1384-2.patch, Tez-1384.patch
>
>
> Currently each entity (DAG, Vertex, Task, TaskAttempt) has some common
> recovery code like log history event and restore from history event. These
> are 2 opposite aspects of recovery. One for store status while the other is
> for restore status. This jira is for putting these pieces of code together (
> in an inner class ). In this way, it is easy to maintain and cut down the
> possibility that one field is not stored or restored.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
