[ 
https://issues.apache.org/jira/browse/TEZ-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135253#comment-14135253
 ] 

Rajesh Balamohan commented on TEZ-1533:
---------------------------------------

lgtm. +1
Minor comment on TestTaskReporter.
{code}
Thread.sleep(2000l);
{code}
This line should be moved before the "verify(mockUmbilical, times(3))" line

> Request Events more often if a complete set of events is received by a task
> ---------------------------------------------------------------------------
>
>                 Key: TEZ-1533
>                 URL: https://issues.apache.org/jira/browse/TEZ-1533
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>              Labels: performance
>         Attachments: TEZ-1533.1.txt
>
>
> If max-events-per-heartbeat events are received by a task, it should turn 
> around and ask for more events - instead of waiting for the standard 
> heartbeat delay.
> For larger jobs, a large chunk of time can otherwise be spent just fetching 
> events - which would unnecessarily block processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to