[ 
https://issues.apache.org/jira/browse/TEZ-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145893#comment-14145893
 ] 

Bikas Saha edited comment on TEZ-1568 at 9/24/14 5:06 AM:
----------------------------------------------------------

bq. This piece of code is used for wait for the handleEvents been called and 
block for Processor, other
I understand that. My question was about this comment in the code
{code} +    @Override
+    public void handleEvents(List<Event> inputEvents) throws Exception {
+      if (this.exLocation == ExceptionLocation.INPUT_HANDLE_EVENTS) {
+        // throw exception here for unit test,
+        // otherwise it should call condition.notify()  <<<<<<<<<<<< HERE
+        throw new Exception(this.exLocation.name());
+      }
+    }{code}
Did you mean to add code here to call condition.notify() in the else stmt?

Why is there a 10s sleep here? Is this to account for the 5s sleep in the AM 
before AM shutdown?
{code}+      stopNonSessionClient();
+      Thread.sleep(10000);
+      stopTezMiniCluster();
+    }{code}


was (Author: bikassaha):
bq. This piece of code is used for wait for the handleEvents been called and 
block for Processor, other
I understand that. My question was about this comment in the code
{code} +    @Override
+    public void handleEvents(List<Event> inputEvents) throws Exception {
+      if (this.exLocation == ExceptionLocation.INPUT_HANDLE_EVENTS) {
+        // throw exception here for unit test,
+        // otherwise it should call condition.notify()  <<<<<<<<<<<< HERE
+        throw new Exception(this.exLocation.name());
+      }
+    }{code}
Did you mean to add code here to call condition.notify() in the else stmt?

Why is there a 10s sleep here? Is this to account for the 5s sleep in the AM?
{code}+      stopNonSessionClient();
+      Thread.sleep(10000);
+      stopTezMiniCluster();
+    }{code}

> Add system test for propagation of diagnostics for errors
> ---------------------------------------------------------
>
>                 Key: TEZ-1568
>                 URL: https://issues.apache.org/jira/browse/TEZ-1568
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1568.patch, Tez-1568-2.patch, Tez-1568-3.patch, 
> Tez-1568-4.patch, Tez-1568-5.patch, Tez-1568-6.patch, Tez-1568-7.patch
>
>
> Design system test where exception come from Input, Output, Processor, 
> InputInitializer and VertexManagerPlugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to