[
https://issues.apache.org/jira/browse/TEZ-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166500#comment-14166500
]
Bikas Saha commented on TEZ-1645:
---------------------------------
The outer and inner if stmts dont seem to make sense. This is not part of the
patch but I noticed it now when I read the code.
{code} if (tezJarUris.length == 1 && (
tezJarUris[0].endsWith(".tar.gz") ||
tezJarUris[0].endsWith(".tgz") ||
tezJarUris[0].endsWith(".zip") ||
tezJarUris[0].endsWith(".tar"))) {
String fileName = tezJarUris[0];
if (fileName.endsWith(".tar.gz") || fileName.endsWith(".tgz")) {{code}
Should we just make this an array?
{code}List<Path> configuredPaths =
Lists.newArrayListWithCapacity(configUris.length);{code}
Conf can probably be removed from the method name now.
"addLocalResourcesFromConf"
Simpler to just save a boolean in the if-stmt of setupTezJarResources() and
return that value?
{code} @Private
static boolean usingTezLibsFromArchive(Map<String, LocalResource> tezLrs) {
- return tezLrs.size() == 1 &&
- tezLrs.keySet().contains(TezConstants.TEZ_TAR_LR_NAME) &&
+ return tezLrs.keySet().contains(TezConstants.TEZ_TAR_LR_NAME) &&
tezLrs.values().iterator().next().getType() ==
LocalResourceType.ARCHIVE;
}{code}
Does validateSetTezAuxLocalResourcesWithFilesAndFolders cover
validateSetTezAuxLocalResources?
> Add support for specifying additional local resources via config
> ----------------------------------------------------------------
>
> Key: TEZ-1645
> URL: https://issues.apache.org/jira/browse/TEZ-1645
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-1645.1.patch, TEZ-1645.2.patch
>
>
> In some cases, there is a need to add additional jars such as lzo or a jar
> for host-rack mapping. Would be useful to have this to ensure that code does
> not need to change for cases such as changing compression codecs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
