[
https://issues.apache.org/jira/browse/TEZ-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179544#comment-14179544
]
Jeff Zhang commented on TEZ-1267:
---------------------------------
[~sseth] Attach the new patch.
The issue I mention is that we have inline call of ROUTE_EVENT_TRANSITION when
handling the events in pendingList, and we assume it would always succeed, just
ignore the returned state. So I separate the real handling TezEvent work into
another method handleRoutedTezEvents(), and call this method when we'd like to
handle the events in the pendingList.
Another comment about the VertexManagerPlugin:
I add "throw Exception" to the methods of VertexManagerPlugin to encourage
people throw exception in future, but don't make changes on the existing
VertexManagerPlugin implementations, because not sure whether it will corrupt
user's existing code.
> Exception handling when Routing Events
> --------------------------------------
>
> Key: TEZ-1267
> URL: https://issues.apache.org/jira/browse/TEZ-1267
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Jeff Zhang
> Priority: Critical
> Attachments: TEZ-1267-2.patch, TEZ-1267-3.patch, Tez-1267.patch
>
>
> Events are generated by user code. In some places they're also handled by
> user code within the AM. Currently, exceptions which are generated when
> handling user code will end up killing the AM (and hence leading to a retry).
> Instead, failure to handle such events, should cause the application to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
