[
https://issues.apache.org/jira/browse/TEZ-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199180#comment-14199180
]
Hitesh Shah edited comment on TEZ-1734 at 11/5/14 10:00 PM:
------------------------------------------------------------
{code}
- } else {
- // Ensure no recovered events
- if (!vertex.recoveredEvents.isEmpty()) {
- throw new RuntimeException("Invalid Vertex state"
- + ", found non-zero recovered events in invalid state"
- + ", recoveredState=" + endState
- + ", recoveredEvents=" + vertex.recoveredEvents.size());
- }
}
{code}
- Could you provide more details on why this is removed?
[~bikassaha] mind taking a look at the unit tests to see if they cover the case
you had looked at earlier?
was (Author: hitesh):
{code}
- } else {
- // Ensure no recovered events
- if (!vertex.recoveredEvents.isEmpty()) {
- throw new RuntimeException("Invalid Vertex state"
- + ", found non-zero recovered events in invalid state"
- + ", recoveredState=" + endState
- + ", recoveredEvents=" + vertex.recoveredEvents.size());
- }
}
{code}
- shouldnt recovered events be dropped only in certain scenarios ( where
vertex has been failed/killed ) and let this check remain around to catch other
bugs?
[~bikassaha] mind taking a look at the unit tests to see if they cover the case
you had looked at earlier?
> Vertex's taskNum may be -1 when recovered from NEW to FAILED/KILLED
> -------------------------------------------------------------------
>
> Key: TEZ-1734
> URL: https://issues.apache.org/jira/browse/TEZ-1734
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.5.1
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-1734.patch
>
>
> When vertex recovered from NEW to FAILED/KILLED, the taskNum may be -1, in
> this case, we don't need to recover its tasks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
