[ 
https://issues.apache.org/jira/browse/TEZ-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201494#comment-14201494
 ] 

Siddharth Seth edited comment on TEZ-1746 at 11/7/14 2:56 AM:
--------------------------------------------------------------

[~jeffzhang] - rather than waiting for initStarted and then sleeping for 1 
second, the test will be more robust if you wait for the expected FINAL state - 
which is FAILED on most of the tests. The test will eventually timeout if the 
state is not reached.

The sequence re-ordering in initialize() looks good though.

Eventually, it may be better to use one of the ControlledInputInitializers - 
but that can wait for a separate jira.


was (Author: sseth):
[~jeffzhang] - rather than waiting for initStarted and then sleeping for 1 
second, the test will be more robust if you wait for the expected FINAL state - 
which is FAILED on most of the tests. The test will eventually timeout if the 
state is not reached.

Eventually, it may be better to use one of the ControlledInputInitializers - 
but that can wait for a separate jira.

> Flaky test in TestVertexImpl and TestExceptionPropagation
> ---------------------------------------------------------
>
>                 Key: TEZ-1746
>                 URL: https://issues.apache.org/jira/browse/TEZ-1746
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.1
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1746.patch
>
>
> *TestVertexImpl*
> {code}
> Error Message
> expected:<FAILED> but was:<INITIALIZING>
> Stacktrace
> java.lang.AssertionError: expected:<FAILED> but was:<INITIALIZING>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:144)
>       at 
> org.apache.tez.dag.app.dag.impl.TestVertexImpl.testExceptionFromII_OnVertexStateUpdated(TestVertexImpl.java:5212)
> {code}
> *TestExceptionProgagation*
> {code}
> Error Message
> test timed out after 180000 milliseconds
> Stacktrace
> java.lang.Exception: test timed out after 180000 milliseconds
>       at java.lang.Thread.sleep(Native Method)
>       at 
> org.apache.tez.dag.api.client.DAGClientImpl._waitForCompletionWithStatusUpdates(DAGClientImpl.java:367)
>       at 
> org.apache.tez.dag.api.client.DAGClientImpl.waitForCompletion(DAGClientImpl.java:213)
>       at 
> org.apache.tez.test.TestExceptionPropagation.testExceptionPropagationSession(TestExceptionPropagation.java:223)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to