[ 
https://issues.apache.org/jira/browse/TEZ-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202742#comment-14202742
 ] 

Siddharth Seth commented on TEZ-1736:
-------------------------------------

Does it make sense to make the toHistoryText methods in each of the individual 
Input / Output configs package private ? (They're marked @Private anyway) That 
has the downside of restricting Input / Output config usage individually, with 
history text. All the usage right now should be via EdgeConfigs though.

UnorderedKVEdgeConfig, UnorderedPartitionedKVEdgeConfig, 
OrderedPartitionedKVEdgeConfig - the createDefault* methods can modify the 
entityDescriptors in place. OrderedPartitionedKVEdgeConfig has one method 
changed, not the other.

May want to modify a test to validate the usage of the property via edge 
configs.


Rest looks good.



> Add support for Inputs/Outputs in runtime-library to generate history text 
> data
> -------------------------------------------------------------------------------
>
>                 Key: TEZ-1736
>                 URL: https://issues.apache.org/jira/browse/TEZ-1736
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-1736.1.patch, TEZ-1736.2.patch, TEZ-1736.3.patch, 
> TEZ-1736.4.patch, TEZ-1736.5.patch, TEZ-1736.6.patch
>
>
> The userpayload related setHistoryText has been available for some time but 
> is not used by the Inputs/Outputs in the run-time library. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to