[
https://issues.apache.org/jira/browse/TEZ-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219450#comment-14219450
]
Prakash Ramachandran commented on TEZ-1757:
-------------------------------------------
overall patch looks fine
* config.js
** typo 'File Wrire Ops', 'HDFS Wrire Ops'
** as config is required to be modified by user please put a one liner
documentation for the url's, counter configs
* helper/misc.js set columnwidth only if not set from the controller (something
like width = width || 150)
* columnselector - needs try catch around localstorage getitem/setitem
* extended-table.js
** would be better to call updatelayout with em.run.once + em.run.next - see
onBodyContentLengthDidChange/elementSizeDidChange
** should _onColumnsChange also observe 'columns', 'columns.@each' ? for ex the
minwidth for a column could have changed. if doing this make sure em.run.once +
em.run.next is used.
minor nitpik - indentation of column selection span, extended table component,
in task.hbs, vertices.hbs. table.commonColumns.counters in config.js
> Column selector for tables.
> ---------------------------
>
> Key: TEZ-1757
> URL: https://issues.apache.org/jira/browse/TEZ-1757
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Sreenath Somarajapuram
> Assignee: Sreenath Somarajapuram
> Attachments: TEZ-1757.1.patch, TEZ-1757.2.patch, TEZ-1757.wip.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
