[ 
https://issues.apache.org/jira/browse/TEZ-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238236#comment-14238236
 ] 

Hitesh Shah commented on TEZ-1734:
----------------------------------

Comments:

{code}
@@ -527,6 +527,7 @@ public class VertexImpl implements 
org.apache.tez.dag.app.dag.Vertex,
           // Ignore-able events
           .addTransition(VertexState.FAILED, VertexState.FAILED,
               EnumSet.of(VertexEventType.V_TERMINATE,
+                  VertexEventType.V_INIT,
{code}
  - why is this needed? Won't the init in failed scenario only occur during 
recovery and not in the normal case? 

Also, is there a guarantee that Vertex Start Event is only written after 
numTasks is setup to a value that is not -1? 

{code}
if (vertex.tasks != null && vertex.numTasks != 0) {
{code}
 - why is this check being removed in the case where recoveryStartEventSeen is 
true? 



> Vertex's taskNum may be -1 when recovered from NEW to FAILED/KILLED
> -------------------------------------------------------------------
>
>                 Key: TEZ-1734
>                 URL: https://issues.apache.org/jira/browse/TEZ-1734
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.1
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1734-2.patch, TEZ-1734.patch
>
>
> When vertex recovered from NEW to FAILED/KILLED, the taskNum may be -1, in 
> this case, we don't need to recover its tasks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to