[
https://issues.apache.org/jira/browse/TEZ-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243295#comment-14243295
]
Hitesh Shah commented on TEZ-1273:
----------------------------------
bq. In session even AM is killed when dag is running, the session will go to
succeeded, does this make sense ? Shouldn't we make it go to killed ?
Are you saying that TezClient::stop was invoked when a DAG was running and the
AM does not go into a KILLED state? That is a bug. However, if
DAGClient::tryKillDAG was killed, then only the DAG should be killed with the
session remaining in a running state.
bq. TezClient.stop is the only way to kill tez-am, , the workaround to kill AM
in non-session is to kill dag then AM will shutdown by itself
This could be done implemented in either manner. One option might be to allow
killing the AM in both modes. [~bikassaha] any comments on this?
bq. For the test of fail to init/start/recover, I make some change on
LocalClient, don't call system.exit, instead just throw exception
Why is system.exit invoked in local mode? This should never happen.
> Refactor DAGAppMaster to state machine based
> --------------------------------------------
>
> Key: TEZ-1273
> URL: https://issues.apache.org/jira/browse/TEZ-1273
> Project: Apache Tez
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: DAGAppMaster_3.pdf, TEZ-1273-3.patch, TEZ-1273-4.patch,
> Tez-1273-2.patch, Tez-1273.patch, dag_app_master.pdf, dag_app_master2.pdf
>
>
> Almost all our entities (Vertex, Task etc) are state machine based and
> written using a formal state machine. But DAGAppMaster is not written on a
> formal state machine even though it has a state machine based behavior. This
> jira is for refactoring it into state machine based
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
