[ 
https://issues.apache.org/jira/browse/TEZ-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254314#comment-14254314
 ] 

Bikas Saha commented on TEZ-286:
--------------------------------

Yes. Recent changes have added task attempt termination cause to the task 
finished event. Its not added to diagnostics string because its free form 
string. Thats probably ok.

> Add terminationCause to diagnostic messages
> -------------------------------------------
>
>                 Key: TEZ-286
>                 URL: https://issues.apache.org/jira/browse/TEZ-286
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Mike Liddell
>              Labels: TEZ-0.2.0
>
> {code}
>  vertex.addDiagnostic("Vertex received Kill in NEW state.");
> {code}
>   - above is just one example but shouldn't termination cause be part of the 
> diagnostic of the object being terminated? If this is already covered in one 
> of the TODO jiras listed in the previous comment, please ignore.
> {code}
> +        String diagnosticMsg = "Vertex killed as other vertex failed. "
> +            + "failedTasks:"
> +            + vertex.failedTaskCount;
> {code}
>   - Not sure if the above diagnostic needs a failed task count.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to