[
https://issues.apache.org/jira/browse/TEZ-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266621#comment-14266621
]
Siddharth Seth commented on TEZ-1898:
-------------------------------------
Should the following just be ignored ? Otherwise, it's possible for
waitTillReady and submitDAG to be invoked in parallel - where submitDAG can win
the race while waitTillReady is sleeping. submitDAG does a sleep of it's own.
{code}org.apache.tez.client.TezClient.waitTillReady() calls Thread.sleep() with
a lock held MT_CORRECTNESS SWL_SLEEP_WITH_LOCK_HELD 654 Medium
{code}
{code}
- if (vargs != null && !vargs.isEmpty()) {
+ if (!vargs.isEmpty()) {
{code}
Does this need a precondition check on vargs
Rest looks good.
> Fix findbugs warnings in tez-api module
> ---------------------------------------
>
> Key: TEZ-1898
> URL: https://issues.apache.org/jira/browse/TEZ-1898
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-1898.1.patch, TEZ-1898.2.patch, TEZ-1898.3.patch
>
>
> https://builds.apache.org/job/PreCommit-Tez-Build/8/artifact/patchprocess/newPatchFindbugsWarningstez-api.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
