[
https://issues.apache.org/jira/browse/TEZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279455#comment-14279455
]
Hitesh Shah edited comment on TEZ-1879 at 1/15/15 10:52 PM:
------------------------------------------------------------
Comments:
{code}
appMaster.appMasterUgi = UserGroupInformation
.createRemoteUser(jobUserName);
appMaster.appMasterUgi.addCredentials(appMaster.amTokens);
{code}
- Can the above ugi instantiation be done in the DAGAppMaster constructor
itself?
{code}
- private Credentials amTokens = new Credentials(); // Filled during init
+ private final Credentials amTokens;
{code}
- LocalClient uses amCredentials where as the AM itself uses amTokens - a
bit confusing. Probably does not need a change right now but might be helpful
for readability.
Rest looks good.
was (Author: hitesh):
Comments:
{code}
appMaster.appMasterUgi = UserGroupInformation
.createRemoteUser(jobUserName);
appMaster.appMasterUgi.addCredentials(appMaster.amTokens);
{code}
- Can the above ugi instantiation be done in the DAGAppMaster constructor
itself?
{code}
- private Credentials amTokens = new Credentials(); // Filled during init
+ private final Credentials amTokens;
{code}
- LocalClient uses amCredentials where as the AM itself uses amTokens - a
bit confusing. Probably does not need a change right now but might be helpful
for readability.
Mostly looks good.
> Create local UGI instances for each task and the AM, when running in LocalMode
> ------------------------------------------------------------------------------
>
> Key: TEZ-1879
> URL: https://issues.apache.org/jira/browse/TEZ-1879
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1879.1.txt, TEZ-1879.2.txt
>
>
> Modifying the client UGI can cause issues when the client tries to submit
> another job - or has tokens already populated in the UGI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
