[
https://issues.apache.org/jira/browse/TEZ-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291813#comment-14291813
]
Prakash Ramachandran commented on TEZ-1973:
-------------------------------------------
* The selection dialog for counters shows space separated counter names.
however logs as well as other screens show with _ . would be better if they
were consistent.
* shuffle error counters seem to be missing from the counters list.
* table controls have the string "Number of Dags to show" hardcoded
* the inputs page has some css issues (lot of gaps between table cells)
* number formatting - would be better to use Number.prototype.toLocaleString
instead of inserting ","
* if the formatting of number is just for display purposes, a handlebars helper
would be better (ex formatteddata in kvtable.js)
* in kvtable.js the formattedData observes just the data array not its contents
(data.@each ?)
* dataprocessor.js - setChildrenInOrder - does it just filter and set children?
how does it order the children?
* dataprocessor.js - isAncestor - it returns true, if vertex passed is same as
this. is this intended?
* dataprocessor.js InputDataNode seems to initialize depth and treeParent,
output does not. not clear if this is intended
* can you include comments on the data structures/algo used in data-processor.
for ex _treefyVertices is very difficult to understand without comments or what
it does.
minor
* this.get('vertex').get('vertexName') can be simplified
this.get('vertex.vertexName')
* just for clarification - why is Input and Ouput changed from route to
resource ?
> Dag View
> --------
>
> Key: TEZ-1973
> URL: https://issues.apache.org/jira/browse/TEZ-1973
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sreenath Somarajapuram
> Assignee: Sreenath Somarajapuram
> Attachments: TEZ-1973.1.patch, TEZ-1973.2.patch, TEZ-1973.3.patch,
> TEZ-1973.4.patch, TEZ-1973.5.patch, TEZ-1973.6.patch
>
>
> Dag View
> 1. Vertex node with name and status
> - Task bubble with count
> - Context sensitive sources/sinks bubble with count
> - Vertex group bubble.
> - Color coded links (Based on type) with support for backward links, to show
> possible issues in the DAG.
> 2. On click redirection for all items.
> - Vertex -> Vertex details page
> - Tasks bubble -> Task list
> - sources/sink bubble -> Sources & sinks page
> - Input -> Respective input's configuration page
> - Output -> Respective output configurations page
> 3. Double click - Toggle display of sources & sinks.
> 4. Panning, zooming, fit button, full screen button.
> 5. Tooltips for all entities.
> 6. Toggling display of sources & sinks.
> 7. Orientation change
> 8. Vertex tooltip customization - Now counters can also be displayed on the
> tooltip.
> 9. Row count selector for all tables.
> 10. Number formatting for counters and configurations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
