[
https://issues.apache.org/jira/browse/TEZ-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297900#comment-14297900
]
Rajesh Balamohan commented on TEZ-1999:
---------------------------------------
Thanks for the comments [~hitesh]
>> Can key ever be empty or null?
It can't be null. But it can be empty in the first iteration.
>> Also, when can prevKey length be less than 0?
Empty DataOutputBuffer's length can be zero. But can't be less than that. Will
change the check accordingly.
>> Might be good to have a more descriptive explanation instead of just a jira
>> id comment.
Sure. Will do
>> Any reason why the fix was not to remove the if check on line 492?
To reduce buffer copying in cases where we find lots of identical keys within
the segment. Will try to simplify it.
> IndexOutOfBoundsException during merge
> --------------------------------------
>
> Key: TEZ-1999
> URL: https://issues.apache.org/jira/browse/TEZ-1999
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rohini Palaniswamy
> Assignee: Rajesh Balamohan
> Attachments: TEZ-1999.1.patch
>
>
> This is most likely due to TEZ-1963
> b2 hits IndexOutOfBoundsException in
> public int compare(byte[] b1, int s1, int l1, byte[] b2, int s2, int l2) {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
