[
https://issues.apache.org/jira/browse/TEZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308939#comment-14308939
]
Sreenath Somarajapuram commented on TEZ-2043:
---------------------------------------------
A trailing space in app.js, vertex_controller.js and dag_vertices.js
Few suggestion:
1. The following can be added into the fractionToPercentage function itself to
reduce duplication.
+ var pct;
+ if (Ember.typeOf(this.get('progress')) === 'number') {
+ pct = App.Helpers.number.fractionToPercentage(this.get('progress')) + '
%';
+ }
+ return pct;
2. Same with the following snippet, it can be defined in one place (may be
dag_controller.js) and reused from other places.
+ if (dag.get('status') === 'RUNNING') {
+ amInfoFetcher = store.find('dagProgress', dag.get('id'), {
+ appId: dag.get('applicationId'),
+ dagIdx: dag.get('idx')
+ })
+ .then(function(dagProgressInfo) {
+ dag.set('progress', dagProgressInfo.get('progress'));
+ })
+ .catch(function(error) {
+ Em.Logger.error('Failed to fetch dagProgress' + error);
+ });
+ loaders.push(amInfoFetcher);
+ }
> tez-ui add progress info from am webservice to dag and vertex views
> -------------------------------------------------------------------
>
> Key: TEZ-2043
> URL: https://issues.apache.org/jira/browse/TEZ-2043
> Project: Apache Tez
> Issue Type: Improvement
> Components: UI
> Reporter: Prakash Ramachandran
> Assignee: Prakash Ramachandran
> Attachments: TEZ-2043.1.patch
>
>
> TEZ-2018 exposes progress info about dag, vertex etc. it would be useful if
> the ui could show progress info in the dag view
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
