[
https://issues.apache.org/jira/browse/TEZ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309583#comment-14309583
]
Siddharth Seth edited comment on TEZ-2045 at 2/6/15 6:42 PM:
-------------------------------------------------------------
Two reasons to reverse the flow. 1) It's cleaner with everything being sent out
of AMContainer instead of one pull. I'd left a note in AMContainerImpl when I
had added this flow earlier. 2) This is a step in the direction of allowing
tasks to be pushed to an external entity, instead of always having a pull model.
This removes pending / running / pullAttempt from AMContainer in favor of
tracking just the current attempt. AMContainer IDLE state now implies that
there's no task assigned to it. RUNNING implies there's a task assigned and the
container has been launched. TezTaskAttemptListenerImpl takes care of tracking
tasks for containers, and ensuring the same task is not sent twice (which
earlier was done by AMContainer).
Not part of the patch at the moment, but planning on renaming
TaskAttemptListenerImplTezDag to TaskAttemptListenerImpl in the commit patch.
was (Author: sseth):
Two reasons to reverse the flow. 1) It's cleaner with everything being sent out
of AMContainer instead of one pull. I'd left a note in AMContainerImpl when I
had added this flow earlier. 2) This is a step in the direction of allowing
tasks to be pushed to an external entity, instead of always having a pull model.
This removes pending / running / pullAttempt from AMContainer in favor of
tracking just the current attempt. AMContainer IDLE state now implies that
there's no task assigned to it. RUNNING implies there's a task assigned and the
container has been launched. TezTaskAttemptListenerImpl takes care of tracking
tasks for containers, and ensuring the same task is not sent twice (which
earlier was done by AMContainer).
> TaskAttemptListener should not pull Tasks from AMContainer
> ----------------------------------------------------------
>
> Key: TEZ-2045
> URL: https://issues.apache.org/jira/browse/TEZ-2045
> Project: Apache Tez
> Issue Type: Task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2045.1.txt
>
>
> The flow should be reversed where AMContainer registers with the
> TaskAttemptListener, like it's done for all other operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
