[
https://issues.apache.org/jira/browse/TEZ-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318652#comment-14318652
]
Hadoop QA commented on TEZ-2064:
--------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698474/TEZ-2064.2.patch
against master revision 54bd104.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/182//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/182//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/182//console
This message is automatically generated.
> SessionNotRunning Exception not thrown is all cases
> ---------------------------------------------------
>
> Key: TEZ-2064
> URL: https://issues.apache.org/jira/browse/TEZ-2064
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Priority: Critical
> Attachments: TEZ-2064.1.patch, TEZ-2064.2.patch
>
>
> Hive handles SessionNotRunning during submitDAG() and restarts the tez-session
> if it receives one. In YHIVE-15, we did not receive that and the query
> failed. In some scenarios the Application will fall out of the RM's knowledge
> and a ApplicationNotFound exception is received instead.
> Here are my asks.
> 1. TezClient.submitDAG()/stop() should return SessionNotRunning exception if
> application is expired. Basically any API which currently returns
> SessionNotRunning should handle the app-not-found scenario.
> 2. It would help if TezClient.getAppMasterStatus() can return
> TezAppMasterStatus.SHUTDOWN if tez-session-application does not exist in RM.
> That way, as a precaution, applications could check before submitting DAG's.
> 3. I think it might be better if verifySessionStateForSubmission() checks the
> app Status every time instead of checking sessionStarted. I am not sure about
> side-effects, but will leave that to your decision.
> If 3 takes time, we can pursue that later. It would really help to get 1 & 2
> in
> the next tez release, especially for busy grids.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
