[ 
https://issues.apache.org/jira/browse/TEZ-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320581#comment-14320581
 ] 

Bikas Saha commented on TEZ-2093:
---------------------------------

bq. for vA-> vC (Scatter Gather) in TestMockDAGAppMaster, do you want to check 
the events for task 0 in vB (i.e near line 205)?
Not sure what you mean. I am checking for task 1 for all destination vertices.

bq. Should put this in constructor or enable this flag using a method
For now, just doing what the existing code is doing. All internal variables can 
be refactored separately.

bq. What about other events besides DM ?
TaskCompleted event is already covered. For the purpose of this test only data 
movement events needed to be covered. Other events can be added as needed. I 
think only input_read_error is left but that is covered in the fault tolerance 
tests.

Thanks for the reviews. Committing.


> Add events to MockDAGAppMaster and add e2e test for event routing
> -----------------------------------------------------------------
>
>                 Key: TEZ-2093
>                 URL: https://issues.apache.org/jira/browse/TEZ-2093
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 0.7.0
>
>         Attachments: TEZ-2093.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to