[ 
https://issues.apache.org/jira/browse/TEZ-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325490#comment-14325490
 ] 

Prakash Ramachandran commented on TEZ-2080:
-------------------------------------------

+1 lgtm other than hitesh's comments.

also not related to the patch - a minor usability improvement - 
does it make sense to set 
TezRuntimeConfiguration.TEZ_RUNTIME_OPTIMIZE_LOCAL_FETCH to true in localclient 
init?
so that to run in localmode for any app all the user would have to do is to 
pass in -D tez.local.mode=true.
the -local command line option in examples would just need to set the 
tez.local.mode to true, instead of configuring for ex defaultFS etc in both 
_execute and localclient

> Localclient should be using tezconf in init instead of yarnconf
> ---------------------------------------------------------------
>
>                 Key: TEZ-2080
>                 URL: https://issues.apache.org/jira/browse/TEZ-2080
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Prakash Ramachandran
>         Attachments: TEZ-2080.1.txt
>
>
> currently in the LocalClient the config used is yarnconf. this should be 
> tezconf.
> {code:title=LocalClient.java}
> @Override
>   public void init(TezConfiguration tezConf, YarnConfiguration yarnConf) {
>     this.conf = yarnConf;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to