[ 
https://issues.apache.org/jira/browse/TEZ-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337350#comment-14337350
 ] 

Hitesh Shah commented on TEZ-1019:
----------------------------------

Sorry for the delay in the review. I still need to do some more manual testing 
on this. 

Some general comments: 
   - routeRecoveredEvents still exists and is part of the recovery flow and 
needs to be kept in sync with the normal event flow. 
   - in restoreForEvent, the code goes through manually defined paths instead 
of using existing transition functions resulting in duplication of logic. 


> Re-factor routing of events to use common code path for normal and recovery 
> flow.
> ---------------------------------------------------------------------------------
>
>                 Key: TEZ-1019
>                 URL: https://issues.apache.org/jira/browse/TEZ-1019
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1019-2.patch, TEZ-1019-3.patch, TEZ-1019-4.patch, 
> TEZ-1019-5.patch, Tez-1019.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to