[ 
https://issues.apache.org/jira/browse/TEZ-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340131#comment-14340131
 ] 

Prakash Ramachandran commented on TEZ-2158:
-------------------------------------------

functionality looks fine. few minor comments.

* task_attempt_controller.js - loadAdditional
** change tabs to space
** task id to be displayed can be a computed function instead of loading it. we 
can avoid an extra hit.
** vertex and dag loading is currently after loading tasks - better to change 
to hash/array of promises
* task_controller.js - same as above
* task_attempt.js - clarification - should the attempt index be just the 
attempt number (0) or the task index + attempt (00_0000_0)


> TEZ UI: Display dag/vertex names, and task/attempt index in breadcrumb
> ----------------------------------------------------------------------
>
>                 Key: TEZ-2158
>                 URL: https://issues.apache.org/jira/browse/TEZ-2158
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-2158.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to