[ 
https://issues.apache.org/jira/browse/TEZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347480#comment-14347480
 ] 

Hadoop QA commented on TEZ-2171:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12702587/TEZ-2171.2.patch
  against master revision c85b724.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/254//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/254//console

This message is automatically generated.

> LLAP: DefaultMetricsSystem.shutdown() should not be called in TezChild
> ----------------------------------------------------------------------
>
>                 Key: TEZ-2171
>                 URL: https://issues.apache.org/jira/browse/TEZ-2171
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: TEZ-2171-TEZ-2003.1.patch, TEZ-2171.1.patch, 
> TEZ-2171.2.patch
>
>
> DefaultMetricsSystem.shutdown() is called in TezChild. IIUC, shutdown is 
> meant to be called in daemon context (datanode/namenode). LLAP daemon 
> initializes the metrics system, after running the first query TezChild shuts 
> down the metrics system which results in closing of all metrics 
> endpoints/sinks. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to