[
https://issues.apache.org/jira/browse/TEZ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347613#comment-14347613
]
Siddharth Seth commented on TEZ-2169:
-------------------------------------
LocalContainerLauncher - does need instrumentation, in the AM.
ContainerReporter seems to have unnecessary changes - clearing NDC in a finally
block which is handled by the callable anyway.
There's some unnecessary imports of NDC in various classes.
There's some additional Threads that are created in ShuffleScheduler and
Shuffle (FetcherOrderedGrouped), which should ideally be instrumented as well.
There is a plan to change some of these over to Executors with Callables /
Runnables - but that's not done yet. This could be deferred to after the
callable/runnable change.
For AM threads, we may want to create a follow up jira - useful to have the
context logged when running in LocalMode only.
[~rajesh.balamohan] - does TEZ-2021 rely on the thread name ? We're not
changing tez-container-log4j.propeties just yet. It may change for LocalMode or
if and when we support multiple executors. Is there a specific format for the
appender which will work with TEZ-2021 ?
[~hitesh] - any thoughts / concerns with this change. Nothing is populated into
the NDC at the moment, as containers run a single task only. The one concern I
have is that this ties us to log4j - that's already the case though with log
file renames and the default logger. Maybe we can move to slf4j instead of
commons-logging in a follow up which supports NDC in it's API.
> LLAP: ensure NDC context is propagated to various threads and pools
> -------------------------------------------------------------------
>
> Key: TEZ-2169
> URL: https://issues.apache.org/jira/browse/TEZ-2169
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: TEZ-2003
>
> Attachments: TEZ-2169.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
