[ 
https://issues.apache.org/jira/browse/TEZ-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353108#comment-14353108
 ] 

Prakash Ramachandran commented on TEZ-2168:
-------------------------------------------

[~hitesh] is there any extra scripts that need to be run before the combined 
patch? tried the patch alone - cant see the renames of files etc. is it 
anything to do with the symbolic links?

{code}
pramachandran@linuxvm:~/tez$ ls -ld 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats
lrwxrwxrwx 1 pramachandran pramachandran 118 Mar  9 08:23 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats
 -> 
../../../../../../../../../../tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/dag/history/logging/ats
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$ patch -p0 < /tmp/TEZ-2168.combined.patch
patching file pom.xml
patching file tez-plugins/pom.xml
patching file tez-plugins/tez-yarn-timeline-history-with-acls/pom.xml
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/main/java/org/apache/tez/dag/history/logging/ats/ATSHistoryLoggingService.java
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/main/java/org/apache/tez/dag/history/logging/ats/HistoryEventTimelineConversion.java
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/dag/history/logging/ats/TestATSHistoryLoggingService.java
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/dag/history/logging/ats/TestATSHistoryWithMiniCluster.java
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java
patching file 
tez-plugins/tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/tests/MiniTezClusterWithTimeline.java
patching symbolic link 
tez-plugins/tez-yarn-timeline-history/src/main/java/org/apache/tez/dag/history/logging/ats
patching file 
tez-plugins/tez-yarn-timeline-history/src/main/java/org/apache/tez/dag/history/logging/ats/ATSHistoryLoggingService.java
patching file 
tez-plugins/tez-yarn-timeline-history/src/main/java/org/apache/tez/dag/history/logging/ats/HistoryEventTimelineConversion.java
patching symbolic link 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats
patching file 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestATSHistoryLoggingService.java
patching file 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestATSHistoryWithMiniCluster.java
patching file 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java
patching symbolic link 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/tests
patching file 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/tests/MiniTezClusterWithTimeline.java
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$ ls -ld 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats
ls: cannot access 
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats:
 No such file or directory
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$
pramachandran@linuxvm:~/tez$ find tez-plugins/tez-yarn-timeline-history -name 
"*.java"
pramachandran@linuxvm:~/tez$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   pom.xml
        modified:   tez-plugins/pom.xml
        modified:   tez-plugins/tez-yarn-timeline-history-with-acls/pom.xml
        modified:   
tez-plugins/tez-yarn-timeline-history-with-acls/src/test/java/org/apache/tez/dag/history/logging/ats/TestATSHistoryWithMiniCluster.java
        deleted:    
tez-plugins/tez-yarn-timeline-history/src/main/java/org/apache/tez/dag/history/logging/ats
        deleted:    
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats
        deleted:    
tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/tests
{code}

> Fix application dependencies on mutually exclusive artifacts: 
> tez-yarn-timeline-history and tez-yarn-timeline-history-with-acls
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-2168
>                 URL: https://issues.apache.org/jira/browse/TEZ-2168
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-2168.1.post-script.patch, 
> TEZ-2168.2.post-script.patch, TEZ-2168.combined.patch, TEZ-2168.file-move.sh
>
>
> Feedback from Chris Wensel on dev list related to simplifying the build file 
> for an app dependent on Tez. 
> Currently, based on hadoop versions, one needs to choose between mutually 
> exclusive artifacts: tez-yarn-timeline-history and 
> tez-yarn-timeline-history-with-acls.
> Suggested options: 
> create a single artifact tez-yarn-timeline-history compiled with a default 
> dep of hadoop 2.6, that includes the Manager. update the TezClient code to 
> gracefully fail if the Manager is not applicable (the runtime env is Hadoop 
> 2.4).
> or
> offer tez-yarn-timeline-history-with-acls as an optional artifact for Hadoop 
> 2.6 deployments, with the single Manager class in it, which in turn requires 
> the tez-yarn-timeline-history artifact -- which is sufficient for a 2.4 
> runtime. if the user provides the additional -with-acls artifact, they are 
> knowingly going to have problems on Hadoop 2.4.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to