[ 
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360295#comment-14360295
 ] 

Hitesh Shah commented on TEZ-2189:
----------------------------------

Minor nit:

{code}
if (!historyUrl.isEmpty() && !historyUrl.startsWith("http://";)) {
{code}
  - above doesn't handle https 
  - we should either just check startsWith "http" instead of "http://"; or 
convert to URI, check for presence/absence of a scheme before prefixing http as 
a default? 

Future jira:
  - AM webapp tracking url does not account for running with https enabled. We 
hardcode the tracking url to use http.



> Tez UI live AM tracking url only works for localhost addresses
> --------------------------------------------------------------
>
>                 Key: TEZ-2189
>                 URL: https://issues.apache.org/jira/browse/TEZ-2189
>             Project: Apache Tez
>          Issue Type: Bug
>          Components: UI
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch, 
> TEZ-2189.4.patch, TEZ-2189.5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to