[
https://issues.apache.org/jira/browse/TEZ-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372097#comment-14372097
]
Hitesh Shah edited comment on TEZ-2210 at 3/20/15 9:01 PM:
-----------------------------------------------------------
Comments:
AsyncDispatcher should remain as it is not meant for use outside of the Tez
project.
{code}
if (null == counters) {
return; // nothing to do.
}
{code}
Why will this ever be null?
protected long getElapsedGc() is not thread-safe.
Can "ManagementFactory.getGarbageCollectorMXBeans()" ever return null?
restoreFromEvent probably does not need a synchronized.
I think the findbugs issue might be fixed if the dag counter is updated in
mayBeConstructFinalFullCounters()
Is " private DAGStatus.State getDAGStatusFromState(DAGState finalState) " no
longer used in the DAGClient code path?
was (Author: hitesh):
Comments:
AsyncDispatcher should remain as it is not meant for use outside of the Tez
project.
{code}
if (null == counters) {
return; // nothing to do.
}
Why will this ever be null?
protected long getElapsedGc() is not thread-safe.
Can "ManagementFactory.getGarbageCollectorMXBeans()" ever return null?
restoreFromEvent probably does not need a synchronized.
I think the findbugs issue might be fixed if the dag counter is updated in
mayBeConstructFinalFullCounters()
Is " private DAGStatus.State getDAGStatusFromState(DAGState finalState) " no
longer used in the DAGClient code path?
> Record DAG AM CPU usage stats
> -----------------------------
>
> Key: TEZ-2210
> URL: https://issues.apache.org/jira/browse/TEZ-2210
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2210.1.patch, TEZ-2210.2.patch, TEZ-2210.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
