[ 
https://issues.apache.org/jira/browse/TEZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375379#comment-14375379
 ] 

Hitesh Shah commented on TEZ-2219:
----------------------------------

Mostly looks good. 

Minor nit: "Should fail due to inputName is null" and "Should fail due to 
ouputName is null" is used for all test cases. Maybe change to "Should fail due 
to invalid ..." so that the sentence makes sense for null, "" and " " cases. 

Feel free to commit after addressing the above comment. +1 pending above 
comment being addressed.

> Should verify the input_name/output_name to be unique per vertex
> ----------------------------------------------------------------
>
>                 Key: TEZ-2219
>                 URL: https://issues.apache.org/jira/browse/TEZ-2219
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2219-1.txt, TEZ-2219-2.patch
>
>
> RuntimeTask try to get the Input/Output using the input_name/output_name, so 
> input_name/output_name should be unique per vertex



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to