[
https://issues.apache.org/jira/browse/TEZ-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383788#comment-14383788
]
Rajesh Balamohan commented on TEZ-2242:
---------------------------------------
+1. lgtm.
- handleVertexStateUpdate(stateUpdate) in onVertexStarted() would be called,
only when the child class calls registerForVertexStateUpdates(). This would not
be invoked in normal codepath.
minor comment
- It mighight not be necessary to synchronize onVertexStarted()? That might fix
the findbugs issue as well.
> Refactor ShuffleVertexManager code
> ----------------------------------
>
> Key: TEZ-2242
> URL: https://issues.apache.org/jira/browse/TEZ-2242
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2242.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
