[
https://issues.apache.org/jira/browse/TEZ-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384231#comment-14384231
]
Bikas Saha edited comment on TEZ-2242 at 3/27/15 5:49 PM:
----------------------------------------------------------
Thanks for the review!
bq. handleVertexStateUpdate(stateUpdate) in onVertexStarted() would be called,
only when the child class calls registerForVertexStateUpdates(). This would not
be invoked in normal codepath.
Not necessarily. This depends on the way state updates are implemented
internally in Tez. E.g. On the same thread the state update invocation could be
triggered as soon as the VM registers for the update (if the target vertex is
already configured). In that case it would end up in pending updates until we
are done with all the initialization in onVertexStarted(). This would have been
the case earlier but not anymore since the VM invocations are offloaded to a
threadpool. However, as user code, the VM code is better off not making such
assumptions if possible.
Trying another patch with more synchronization to fix the bogus findbugs.
was (Author: bikassaha):
bq. handleVertexStateUpdate(stateUpdate) in onVertexStarted() would be called,
only when the child class calls registerForVertexStateUpdates(). This would not
be invoked in normal codepath.
Not necessarily. This depends on the way state updates are implemented
internally in Tez. E.g. On the same thread the state update invocation could be
triggered as soon as the VM registers for the update (if the target vertex is
already configured). In that case it would end up in pending updates until we
are done with all the initialization in onVertexStarted(). This would have been
the case earlier but not anymore since the VM invocations are offloaded to a
threadpool. However, as user code, the VM code is better off not making such
assumptions if possible.
Trying another patch with more synchronization to fix the bogus findbugs.
> Refactor ShuffleVertexManager code
> ----------------------------------
>
> Key: TEZ-2242
> URL: https://issues.apache.org/jira/browse/TEZ-2242
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2242.1.patch, TEZ-2242.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
