[ 
https://issues.apache.org/jira/browse/TEZ-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484825#comment-14484825
 ] 

Prakash Ramachandran commented on TEZ-2273:
-------------------------------------------

overall patch looks good. few questions
* if there is a filter and a sort requested, the order of operation seems to be 
sort , filter. shouldn't this be reversed (for ex it would filter out most of 
data and then sort it).
* why is both the contentPath and getCellContent required for all the columns, 
isn't it supposed to be one or the other? 
* found a few issues with regex, some of them throw error without any feedback 
to user ex. * (correct one being .*), could not figure how to filter multiple 
columns .
* there is probably a race condition where the vertex name does not get 
displayed - reproduction - go to all tasks page of one dag, go back to all 
dags, go to another dag all tasks, check if the vertex name is getting 
displayed. at times i was seeing vertex id instead. a refresh would show the 
vertex name.
* status message is missing while sorting at times.


> TEZ UI: Support client side, searching & sorting.
> -------------------------------------------------
>
>                 Key: TEZ-2273
>                 URL: https://issues.apache.org/jira/browse/TEZ-2273
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-2273.1.patch
>
>
> Support search and sorting in basic-ember-table component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to