[
https://issues.apache.org/jira/browse/TEZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485682#comment-14485682
]
Hitesh Shah edited comment on TEZ-2233 at 4/8/15 6:12 PM:
----------------------------------------------------------
Comments:
{code}
* @param sourceEdgeProperties
* Map with Key=name of {@link Edge} to be updated and Value=
* {@link EdgeProperty}
{code}
- are we introducing naming for edges or is this the destination vertex name?
Maybe clarify in the docs that name is actually the destination vertex name?
{code}
checkAndThrowIfDone()
{code}
- a better name would be useful. Does this throw an exception back to the
plugin or fail the vertex?
In VertexManagerPlugin, shouldn't reconfigureVertex() have a declared throw for
TezException so that the user writing the plugin knows that this function can
throw back an exception? We can then specialize TezException for various error
cases.
was (Author: hitesh):
Comments:
{code}
* @param sourceEdgeProperties
149 * Map with Key=name of {@link Edge} to be updated and Value=
150 * {@link EdgeProperty}
{code}
- are we introducing naming for edges or is this the destination vertex name?
Maybe clarify in the docs that name is actually the destination vertex name?
{code}
checkAndThrowIfDone()
{code}
- a better name would be useful. Does this throw an exception back to the
plugin or fail the vertex?
In VertexManagerPlugin, shouldn't reconfigureVertex() have a declared throw for
TezException so that the user writing the plugin knows that this function can
throw back an exception? We can then specialize TezException for various error
cases.
> setParallelism should allow setting built-in edge managers
> ----------------------------------------------------------
>
> Key: TEZ-2233
> URL: https://issues.apache.org/jira/browse/TEZ-2233
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2233.1.patch
>
>
> Currently, all edge managers set during setParallelism end up becoming custom
> edges. However, just like during dag creation, it should be possible to
> specify standard edge types like scatter_gather if that is what the final
> user decision is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
