[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511335#comment-14511335
]
Hitesh Shah commented on TEZ-2226:
----------------------------------
Comments:
{code}
} else {
dag.setConf(TezConfiguration.TEZ_DAG_HISTORY_LOGGING, "false");
}
{code}
- does this work correctly for simple history logger where there are no acl
managers involved? I am guessing this might be disable logging for all dags
when a simple history logger is in place?
{code}
if (!amConfig.getTezConfiguration().
359 getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED,
360
YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) {
361 historyACLPolicyManager = null;
362 }
{code}
- why is this needed? the acl manager should not be created when timeline is
disabled - correct?
{code}
dag.setConf(TezConfiguration.TEZ_DAG_HISTORY_LOGGING, "true");
{code}
- this should not be needed as default true should always kick in if the
config is not present.
Minor nit: rename dagSubmittedEvent.getDagLogging() to something along the
lines of logging enabled.
Mostly looking good. Getting close to a final patch. Will try out the patch for
manual testing. You can try the same by leveraging TestOrderedWordCount to run
multiple dags and manually bring ATS up/down between dags. Take a look at the
INTER_JOB_SLEEP_INTERVAL param in the code to control the time interval between
2 dag submissions.
> Disable writing history to timeline if domain creation fails.
> -------------------------------------------------------------
>
> Key: TEZ-2226
> URL: https://issues.apache.org/jira/browse/TEZ-2226
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Chang Li
> Priority: Blocker
> Attachments: TEZ-2226.2.patch, TEZ-2226.3.patch, TEZ-2226.4.patch,
> TEZ-2226.5.patch, TEZ-2226.6.patch, TEZ-2226.7.patch, TEZ-2226.8.patch,
> TEZ-2226.9.patch, TEZ-2226.patch, TEZ-2226.wip.2.patch, TEZ-2226.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
