[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511723#comment-14511723
]
Chang Li edited comment on TEZ-2226 at 4/24/15 9:04 PM:
--------------------------------------------------------
[~hitesh] Thanks for valuable review and feedback! I also feel that I had abuse
using timeline_enabled. I have created a new config setting to ensure all dags
within that session will have dag logging turned off. Have also corrected other
places you point out. Did manually run jobs and verified that logging is turned
on and off as expected. As for the recovery issue, I pass the
TEZ_DAG_HISTORY_LOGGING flag from client to am as part of dagplan. Even if am
crashes and then restarts, I believe if DAGAppMaster called startDAG with the
same dagplan it can still see the flag and function correctly.
was (Author: lichangleo):
[~hitesh] Thanks for valuable review and feedback! I also feel that I had abuse
using timeline_enabled. I have created a new config setting to ensure all dags
within that session will have dag logging turned off. Have also corrected other
places you point out. Did manually run jobs and verified that logging is turned
on and off as expected. As for the recovery issue, I pass the
TEZ_DAG_HISTORY_LOGGING flag from client to am as part of dagplan, even though
am crashes and then restarts, I believe if DAGAppMaster called startDAG with
the same dagplan it can still see the flag and function correctly.
> Disable writing history to timeline if domain creation fails.
> -------------------------------------------------------------
>
> Key: TEZ-2226
> URL: https://issues.apache.org/jira/browse/TEZ-2226
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Chang Li
> Priority: Blocker
> Attachments: TEZ-2226.10.patch, TEZ-2226.2.patch, TEZ-2226.3.patch,
> TEZ-2226.4.patch, TEZ-2226.5.patch, TEZ-2226.6.patch, TEZ-2226.7.patch,
> TEZ-2226.8.patch, TEZ-2226.9.patch, TEZ-2226.patch, TEZ-2226.wip.2.patch,
> TEZ-2226.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
