[ 
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517127#comment-14517127
 ] 

Prakash Ramachandran commented on TEZ-2226:
-------------------------------------------

+1 LGTM. 

one minor item (separate JIRA) could be in DAGClientImpl to not read from 
timeline if writes are disabled.

> Disable writing history to timeline if domain creation fails.
> -------------------------------------------------------------
>
>                 Key: TEZ-2226
>                 URL: https://issues.apache.org/jira/browse/TEZ-2226
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Chang Li
>            Priority: Blocker
>         Attachments: TEZ-2226.10.patch, TEZ-2226.11.patch, TEZ-2226.12.patch, 
> TEZ-2226.2.patch, TEZ-2226.3.patch, TEZ-2226.4.patch, TEZ-2226.5.patch, 
> TEZ-2226.6.patch, TEZ-2226.7.patch, TEZ-2226.8.patch, TEZ-2226.9.patch, 
> TEZ-2226.addon-for-patch10, TEZ-2226.addon-for-patch10-combined.full.patch, 
> TEZ-2226.patch, TEZ-2226.wip.2.patch, TEZ-2226.wip.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to