[ 
https://issues.apache.org/jira/browse/TEZ-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518728#comment-14518728
 ] 

Gopal V commented on TEZ-2383:
------------------------------

[~rajesh.balamohan]: This is likely to be a fix limited to the sort 
implementation.

You can broaden this fix to all possible edge types, by moving up the 
abstraction.

Since ProcessorContext is the visible opaque implementation setup for the 
tez-api, it would be better to clean up that chain of references - cleaning up 
TezTaskContextImpl::runTimeTask within the ProcessorContext impl when the 
logical IO processor close is called.

This follows a neat contract as any user-code which holds onto a processor 
context object after the close of the task runtime will be holding onto an 
empty/unusable shell of a context.

> release sort buffers on close
> -----------------------------
>
>                 Key: TEZ-2383
>                 URL: https://issues.apache.org/jira/browse/TEZ-2383
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>         Attachments: TEZ-2383.1.patch
>
>
> Currently they get released when sorter object gets GC-ed, but it might be 
> good to explicitly release them on close as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to