[
https://issues.apache.org/jira/browse/TEZ-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522002#comment-14522002
]
Bikas Saha commented on TEZ-2360:
---------------------------------
On separate lines please to follow existing code convention
{code}+ TezCounter modifiedCounter, originalCounter;{code}
Sorry I missed the sum check in the previous review.
A similar non-zero check for output edges would be good.
{code}+ assertTrue("At least one of the counter should be non-zero. invalid
test ", nonZeroCounters > 0);{code}
Unnecessary diffs?
{code}- job.run(tezConf, new String[] { StringUtils.join(",",
inputPaths),
- StringUtils.join(",", outputPaths), "2" }, null) == 0);
+ job.run(tezConf, new String[]{StringUtils.join(",", inputPaths),
+ StringUtils.join(",", outputPaths), "2"}, null) == 0);
for (int i=0; i<numIterations; ++i) {
verifyOutput(outputDirs[i], remoteFs);
@@ -732,8 +837,8 @@ public class TestTezJobs {
remoteFs.mkdirs(inputDir);
String outputDirStr = "/tmp/owc-output";
outputPaths[0] = outputDirStr;
- job.run(tezConf, new String[] { StringUtils.join(",", inputPaths),
- StringUtils.join(",", outputPaths), "2" }, null);
+ job.run(tezConf, new String[]{StringUtils.join(",", inputPaths),
+ StringUtils.join(",", outputPaths), "2"}, null);{code}
The above comments are minor. Please feel free to commit after fixing them.
Thanks!
> per-io counters flag should generate both overall and per-edge counters
> ------------------------------------------------------------------------
>
> Key: TEZ-2360
> URL: https://issues.apache.org/jira/browse/TEZ-2360
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Prakash Ramachandran
> Attachments: TEZ-2360.1.patch, TEZ-2360.2.patch, TEZ-2360.3.patch,
> TEZ-2360.4.patch
>
>
> Currently, the per-io flag disables overall per task counters and retains
> only per edge counters. It would be useful to have both overall and per edge
> counters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
