[ 
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527830#comment-14527830
 ] 

Hitesh Shah edited comment on TEZ-2221 at 5/5/15 3:06 AM:
----------------------------------------------------------

This implies that oA ( or oB ) cannot belong to 2 different vertex groups and 
therefore the check currently implemented probably needs to be changed to 
account for this and not be based on vertex members of the group. 

[~bikassaha] [~zjffdu] if the above is correct, it seems that we should revert 
this commit? Agree?


was (Author: hitesh):
This implies that oA ( or oB ) cannot belong to 2 different vertex groups and 
therefore the check currently implemented probably needs to be changed to 
account for this and not be based on vertex members of the group. 

> VertexGroup name should be unqiue
> ---------------------------------
>
>                 Key: TEZ-2221
>                 URL: https://issues.apache.org/jira/browse/TEZ-2221
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.7.0, 0.5.4, 0.6.1
>
>         Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch, TEZ-2221-3.patch, 
> TEZ-2221-4.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex 
> group name to identify the vertex group commit, the same name of vertex group 
> will conflict. While in the current equals & hashCode of VertexGroup, vertex 
> group name and members name are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to