[
https://issues.apache.org/jira/browse/TEZ-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529031#comment-14529031
]
Bikas Saha commented on TEZ-2410:
---------------------------------
Extra space vertexGroup.successfulCommits ++;
The new VertexGroupStatus enum is duplicating the logic that is being encoded
in successfulCommits because all the enums can be represented as methods on
VertexGroupInfo which use a combination of "committed" and "successfulCommits".
So it may be better to use new methods on VertexGroupInfo instead of having 2
ways of representing the same thing which may go out of sync as code evolves.
In the new/existing tests, we probably needs a couple of extra checks
1) For normal vertices we do not write a group commit finished event. (the
patch does not seem to cover any of these)
2) For groups we only write the group commit finished event once. (the patch
covers some of these)
> VertexGroupCommitFinishedEvent is not logged correctly
> ------------------------------------------------------
>
> Key: TEZ-2410
> URL: https://issues.apache.org/jira/browse/TEZ-2410
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Priority: Blocker
> Fix For: 0.7.0
>
> Attachments: TEZ-2410-1.patch
>
>
> VertexGroupCommitFinishedEvent may be logged for non-vertex group commits.
> VertexGroupCommitFinishedEvent may be logged for each member vertex of the
> group instead of once per group.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
