[ 
https://issues.apache.org/jira/browse/TEZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542346#comment-14542346
 ] 

Hitesh Shah commented on TEZ-2076:
----------------------------------

Comments: 

Minor nit: pom.xml change not needed as version is already specified in 
pluginMgmt section. 
tez-plugins/tez-history-parser/pom.xml is missing a maven-jar-plugin section to 
add a mainClass. My mistake for not catching this earlier. This will impact 
usage and javadocs. A user can still specify the classname optionally but not 
needed if the mainClass is ATSImportTool.

Does yarnTimelineAddress need http:// prefix or would a.b.c.d:8188 suffice? If 
the former, maybe a simple check or fix might be to prefix with http:// if the 
user has not specified it?

Pending comments from earlier:
  -  there is both a ctor and init() which is causing some confusion in how 
some fields are initialized. Not sure why there is a need for both functions. 
Maybe just combine everything into the ctor? Will help make some more fields 
final. init() can also be used if needed for testing but can be called from the 
ctor itself.

 

 











> Tez framework to extract/analyze data stored in ATS for specific dag
> --------------------------------------------------------------------
>
>                 Key: TEZ-2076
>                 URL: https://issues.apache.org/jira/browse/TEZ-2076
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>         Attachments: TEZ-2076.1.patch, TEZ-2076.10.patch, TEZ-2076.11.patch, 
> TEZ-2076.12.patch, TEZ-2076.13.patch, TEZ-2076.2.patch, TEZ-2076.3.patch, 
> TEZ-2076.4.patch, TEZ-2076.5.patch, TEZ-2076.6.patch, TEZ-2076.7.patch, 
> TEZ-2076.8.patch, TEZ-2076.9.patch, TEZ-2076.WIP.2.patch, 
> TEZ-2076.WIP.3.patch, TEZ-2076.WIP.patch
>
>
> - Users should be able to download ATS data pertaining to a DAG from Tez-UI 
> (more like a zip file containing DAG/Vertex/Task/TaskAttempt info).
> - This can be plugged to an analyzer which parses the data, adds semantics 
> and provides an in-memory representation for further analysis.
> - This will enable to write different analyzer rules, which can be run on top 
> of this in-memory representation to come up with analysis on the DAG.
> - Results of this analyzer rules can be rendered on to UI (standalone webapp) 
> later point in time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to