[
https://issues.apache.org/jira/browse/TEZ-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556952#comment-14556952
]
Hitesh Shah commented on TEZ-1529:
----------------------------------
Looks good for the most part.
Minor comments:
- split tests in TestTimelineReaderFactory into 2 functions
- should tokenDelegationSupported be synchronized from a safety perspective?
- DEFAULT_SOCKET_TIMEOUT - can this be changed to re-use an existing timeout
config instead of either using a hardcoded value or introducing a new config.
- " // reads are supported for non-secure cluster from hadoop 2.5 and
up." - shouldn't this be 2.4?
- the file TimelineReaderStrategy is pretty big. Might be good to add a
summary doc at the very top.
- using a version check similar to TestATSHttpClient, can we add some
version specific tests for 2.4?
> ATS and TezClient integration in secure kerberos enabled cluster
> -----------------------------------------------------------------
>
> Key: TEZ-1529
> URL: https://issues.apache.org/jira/browse/TEZ-1529
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Prakash Ramachandran
> Assignee: Prakash Ramachandran
> Priority: Blocker
> Attachments: TEZ-1529-branch6.2.patch, TEZ-1529.1.patch,
> TEZ-1529.2.patch, TEZ-1529.3.patch, TEZ-1529.4.patch
>
>
> This is a follow up for TEZ-1495 which address ATS - TezClient integration.
> however it does not enable it in secure kerberos enabled cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
